Bug fixes from parsing industrial cases - #62
Merged
Merged
Conversation
RMA/RMI bracket a winding's turns ratio in the record's CW units. The ratio itself was converted to per unit, but the limits were passed through as read, so under CW=2 a per-unit tap sat against a band in kV. Both transformer paths now build the factor that maps a CW-unit WINDV onto the modeled ratio and apply that one factor to the ratio and to its limits: the 2W `tap` (which also divides by WINDV2) and each 3W winding's turns ratio. The phase-shift objectives (|COD| 3 or 5) bracket an angle in degrees and are left as read. `ext` keeps the record's own values.
A SUBSTATION record with an empty node block attaches to no bus, so it has no bus-branch representation. `_psse2pm_substation_data!` emitted it anyway, and the OpenAPI reader, which associates each substation with the buses its nodes name, rejected the whole file. The conversion now skips such records and reports the count once. A skipped record that still carries switching devices or terminals references nodes that do not exist, so it also gets its own warning. pti.jl keeps every record, and `read_substations!` keeps its throw as an invariant check.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jd-lara
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CW=2. Note that this does not resolve the semantic issues of the control limit fields depending on the control. This is being address separately by @annacasavant