Move the OpenAPI emit layer to OpenAPI.jl 1.x and restore the suite - #58
Open
jd-lara wants to merge 6 commits into
Open
Move the OpenAPI emit layer to OpenAPI.jl 1.x and restore the suite#58jd-lara wants to merge 6 commits into
jd-lara wants to merge 6 commits into
Conversation
gen_status maps to ONLINE or OFFLINE instead of a boolean.
Same shape as PowerTableDataParser: Staged{T} plus materialize replaces
construct-then-mutate, discriminators and ABSENT follow the 1.x runtime, and the
OpenAPI packages resolve from the sibling checkout. Suite is not yet green.
VSC converter losses build the LossCurve wrapper; remote_bus_control_from/to take the schema's explicit null; prime_mover_type and operation_cost stage before the fields whose units depend on them; the staged-builder layer resolves discriminated units and oneOf fields. Tests use the staged API and assert 1.x semantics. Suite: 2444 passed.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
`("SwitchedAdmittance", :solved_admittance) => :skip` appeared twice in the
same Dict literal, where Julia silently keeps the last; keep the entry under
the BINIT comment that explains it. The six `IC.APIModel` methods behind the
3-arg `get_value` had no callers -- every real call passes a `Staged` -- so
they went with the "or an already-materialized one" claim in the docstring.
Factor the LossCurve nest built identically at three sites into `_loss_curve`,
and trim the staging-order rationale restated at five call sites to pointers
at `_shadow`, which documents it once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the OpenAPI emit layer to OpenAPI.jl 1.x and restores the suite on the regenerated packages (SiennaSchemas
b49f2b8).What changed
stage,set_value!,materialize) because the generated structs are immutable;add_component!materializes once every field is staged. Discriminators andABSENTfollow the 1.x runtime.LossCurvewrapper the schema requires;remote_bus_control_from/toaccept the schema's explicitnull; enum-dependent unit lookups stageprime_mover_typeandoperation_costbefore the fields whose units depend on them.number_engaged,solved_admittance, no fixedY;FixedAdmittance.yandy_increaseare the sharedComplexNumber.ABSENT, materialized values are copies,check_requiredis enforced bydecode).Test plan
julia --project=test test/runtests.jl— 2444 passed, 0 failed, 0 errored🤖 Generated with Claude Code
https://claude.ai/code/session_01QDkZStcFzebhh9XFpPKRSo