Follow the DeviceBaseUnit -> ComponentBaseUnit rename in the docs - #56
Merged
Conversation
InfrastructureSystems#634 and PowerSystems#1791 renamed the per-unit marker: `DU`/`DeviceBaseUnit` are now `CU`/`ComponentBaseUnit`. PFFP names no marker in code -- it writes the OpenAPI wire format, whose `power_units` spelling (`COMPONENT_BASE`/`NATURAL_UNITS`) comes from SiennaSchemas and did not change, and `IS.UnitSystem.DEVICE_BASE` was not renamed -- so this is comments and docstrings only, describing the PowerSystems importer these documents are written for. The `device_base.jl` filename and the `_DEVICEBASE_*` constant names are deliberately left alone: renaming them would collide with the open work in #42 and #55 across the same files for no behavioural gain. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LP6eB1zx4eyE3hd7tpvSue
Two more prose sites the first pass missed: the qualified `IS.DU` in make_thermal_cost's docstring and a `PSY.DU` aside in the branch tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LP6eB1zx4eyE3hd7tpvSue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to InfrastructureSystems#634 / PowerSystems#1791, which renamed the per-unit marker
DU/DeviceBaseUnittoCU/ComponentBaseUnit.Nothing in PFFP breaks. The parser names no unit marker in executable code: it writes the OpenAPI wire format, whose
power_unitsspelling (COMPONENT_BASE/NATURAL_UNITS) comes from SiennaSchemas and is unchanged, andIS.UnitSystem.DEVICE_BASEwas not renamed by the IS PR — only the marker singleton types were. So every reference here is prose describing the PowerSystems importer these documents are written for, and stale prose naming a type that no longer exists is what this fixes.Eight lines across four files:
src/openapi/build.jl,src/openapi/cost.jlsrc/openapi/device_base.jl(×5)test/test_openapi_branch.jlDeliberately not changed: the
device_base.jlfilename and the_DEVICEBASE_*constant names. Renaming those would touch the same files as the open #42 and #55 for no behavioural gain; worth doing once those land, if at all.🤖 Generated with Claude Code
https://claude.ai/code/session_01LP6eB1zx4eyE3hd7tpvSue