fix: keep a zero-impedance TRANSFORMER classified as a transformer - #53
Merged
Merged
Conversation
Port of PowerSystems.jl 00003f06d. _branch_type_psse checked for zero r/x before checking the transformer flag, so a TRANSFORMER record with R1-2 = X1-2 = 0 was routed to make_switch_from_zero_impedance_branch! and became a DiscreteControlledACBranch. It also slipped past the "transformer=true but detected as a Line" guard, which only catches :line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HmGuSdKu4g7a3uqgPXZ4NC
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jd-lara
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports PowerSystems.jl 00003f06d, which landed after the parsing code moved here.
_branch_type_pssetested for zerobr_r/br_xbefore checkingd["transformer"], so a TRANSFORMER record withR1-2 = X1-2 = 0became aDiscreteControlledACBranch— silently, since thetransformer=true but detected as a Lineguard only catches:line.🤖 Generated with Claude Code
https://claude.ai/code/session_01HmGuSdKu4g7a3uqgPXZ4NC