fix: per-unitize VSC converter BLOSS on the DC base kV - #52
Merged
Merged
Conversation
Port of PowerSystems.jl 11562cc4b. BLOSS is kW per DC ampere, so the LinearCurve slope is p.u. power per p.u. current — BLOSS / base_kV — not BLOSS / (1000 * baseMVA), which is not dimensionless. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HmGuSdKu4g7a3uqgPXZ4NC
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jd-lara
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports PowerSystems.jl 11562cc4b, which landed after the parsing code moved here.
BLOSSis kW per DC ampere, so itsLinearCurveslope is p.u. power per p.u. current —BLOSS / base_kV— notBLOSS / (1000 * baseMVA), which is not dimensionless.ALOSS/MINLOSSare plain kW and keep their/(1000 * baseMVA). Regression test added against the existingsynthetic_v35_vsc_line.rawfixture.🤖 Generated with Claude Code
https://claude.ai/code/session_01HmGuSdKu4g7a3uqgPXZ4NC