Per-component power_units emission and the OpenAPI package split - #50
Merged
Merged
Conversation
Power-bearing components carry power_units in place of parameter_units, and the OpenAPI read/write paths and their fixtures follow the renamed field. Pins the schema-generated packages at PowerOpenAPIModels jd/schemas-0.1.0 and PowerSystems at jd/power-units-rename, which carry the matching rename.
The CostCurve schema marks vom_cost required and declares a zero linear input-output curve as its default, but the 0.1.0 regeneration no longer carries object defaults into the generated models, so a writer that omits the field emits a document that fails validation.
Domain-neutral value shapes and the document registry moved to InfrastructureCoreOpenAPIModels; qualified references follow (IC alias), the time-series package rename lands in the pins, and the pins track the split branches until they merge. Full suite: 2419/2419; emitted documents pass the cross-language compatibility check both directions.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser emits self-interpretable component blobs per the 0.1.0 schemas: no document-level
unit_system/base_power, per-componentpower_unitsstamps,variable_operation_cost, andvom_coston every cost curve. Follows the PowerOpenAPIModels package split (Sienna-Platform/PowerOpenAPIModels#11): domain-neutral shapes and the document registry resolve fromInfrastructureCoreOpenAPIModels.Verification: full suite 2419/2419; emitted 14-bus documents pass the Python cross-language compatibility check in both directions.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FYWx3EqRR3kUCf1efCAxHn