Conversation
Add `set_start_value!(container, variable, value)`, which applies a start value only when warm start is enabled, and use it in the device and service variable builders. Downstream builders that create variables directly call the same function, so `warm_start = false` reaches the solver with no start values. Add a `skip_variable(V, device, F)` hook that leaves a device off a variable's axis, so downstream builders that only filtered devices can use the generic builder.
Contributor
|
Performance Results This branch |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
luke-kiernan
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A model built with
warm_start = falsecould still reach the solver with start values.Builders that create variables outside IOM's
add_variables!had to check the setting themselves, and several in POM didn't.A partial MIP start is expensive: on a 24-hour nodal ERCOT day-ahead model, Gurobi spent 29 minutes completing one before presolve.
Changes
set_start_value!(container, variable, value)applies a start value only when warm start is enabled, and does nothing fornothing.The device and service variable builders now use it.
It is exported so downstream builders that create variables directly can call it.
skip_variable(V, device, F)(defaultfalse) letsadd_variables!leave a device off a variable's axis.POM uses it to drop must-run units from thermal commitment variables, which removes a custom builder.
Tests
test/test_start_values.jlcoversset_start_value!under both settings, the device builder's warm-start hook, andskip_variable, including the case where every device is skipped.Companion POM PR: Sienna-Platform/PowerOperationsModels.jl#329
🤖 Generated with Claude Code