Conversation
`IS.@scoped_enum` now wraps `EnumX.@enumx`, so a scoped enum's type is `Name.Value` and the bare name is a module. Value uses are unchanged; type positions move, as do the `ENUMS` table and its lookups, which key on the type. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Performance Results This branch |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IS.@scoped_enumnow wrapsEnumX.@enumx(IS #643, merged into IS4), so a scoped enum's type isName.Valueand the bare name is a module. Value uses (TableFormat.LONG) are unchanged; what moves is type positions.ModelBuildStatus/SimulationBuildStatus/RunStatus/TableFormatannotations, and IOM's ownSOSStatusVariableandOptimizationModelExportFormat.ENUMSand theENUM_MAPPINGSbuilt from it key on the enum type, so they take.Valuetoo — the load-timeinstancesloop over them is what would otherwise stop the package precompiling.The IS pin already points at IS4, which now carries EnumX; no pin changes needed.
🤖 Generated with Claude Code