Pass the evaluation data into calculate_aux_variable_value! - #168
Merged
Merged
Conversation
The loop already holds the evaluator that just ran, so hand it to the aux-var calculation instead of making the implementation look it up. POM's power-flow read-back searched for it with a `findlast` over a `Dict`, which returns an arbitrary evaluator once more than one is registered. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Performance Results This branch |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jd-lara
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculate_aux_variables!already holds the evaluator it just ran, so pass it tocalculate_aux_variable_value!rather than making the implementation find it again. POM's power-flow read-back was finding it with afindlastover aDict, which returns an arbitrary evaluator as soon as more than one is registered (Sienna-Platform/PowerOperationsModels.jl#308); the POM-side PR that deletes that search and adds the multi-evaluator tests depends on this one.🤖 Generated with Claude Code