Merge main into jd/market_models2 - #167
Closed
rodrigomha wants to merge 8 commits into
Closed
rodrigomha wants to merge 8 commits into
rodrigomha wants to merge 8 commits into
Conversation
Template types can share objects with the caller's original by reference after the build-time copy: objects a build mutates that callers then inspect on the instance they passed in. The default shares nothing. The network-data sharing that must happen before deepcopy is unchanged, now under _deepcopy_sharing_network_data.
…nces Add share_template_references! hook to the template deep copy
InfrastructureSystems#634 renamed the per-unit marker: `IS.DU`/ `IS.DeviceBaseUnit` are now `IS.CU`/`IS.ComponentBaseUnit`, with no shims. Seven sites, all constructing the marker to parameterize a cost curve in the value-curve tests, plus the units tuple in the dispatch-profile script. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LP6eB1zx4eyE3hd7tpvSue
Follow the DeviceBaseUnit -> ComponentBaseUnit rename
InfrastructureSystems 2a2494ec moved the unit-system base arithmetic out of convert_cost_coefficient, which now takes a bare x-axis ratio, so every cost path failed on the IS4 head with a MethodError. _system_base_ratio derives the ratio the way IS used to (SU 1, CU sb/db, NU sb) and the four per-system-unit helpers pass it through; a unit test pins the three ratios for each helper.
Coverage.jl caps HTTP at 1.x and the OpenAPI.jl 1.x packages need HTTP 2.x, so the test environment has not resolved since the IS4 pin moved, on CI and locally. CI collects coverage through julia-processcoverage and never loaded the package; the local lcov script now runs from scripts/coverage, its own environment.
Derive the cost-coefficient ratio to the system base ourselves
Brings IOM #166: cost conversions derive their ratio to the system base (IS 2a2494ec changed convert_cost_coefficient), and the coverage tooling leaves the test environment.
Contributor
|
Performance Results This branch |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Superseded: jd/market_models2 is rebased onto main directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
mainup to and including #166 into the market-models branch: cost conversions derive their ratio to the system base after InfrastructureSystems 2a2494ec changedconvert_cost_coefficient, and the coverage tooling leaves the test environment (Coverage.jl caps HTTP at 1.x, the OpenAPI packages need 2.x). No conflicts. PowerOperationsModels'jd/market_models2needs this to build on the OpenAPI 1.x line; its follow-up PR pins this branch until it merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01XgUkJVy9F23R3G5F8XFaLj