Skip to content

get_value downstream override performance #118

Description

@luke-kiernan

I liked the solution of having get_value be @generated, but now due to EmulationModel details, instead of straight :(return getfield(store, $field)[$K(T, U)]), we have :(return get_data_field(store, Val($field))[$K(T, U)]) so downstream packages can override it. I suspect that messes with the @generated-ness. Also, Val(foo) is sometimes surprisingly expensive.

Look into the pre-compilation/performance impacts of this and decide if it's worthwhile (and feasible) to come up with something better.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions