Repository navigation
docs(adr): 0020 versioning is the hand-set <Version> that the tag guard checks - #292
Merged
Merged
Conversation
ShortArrow
marked this pull request as ready for review
October 20, 2026 00:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR 0020 §8 said releases are versioned by Nerdbank.GitVersioning, from a
version.jsonat the root and a patch computed from the commit height. Neither was ever in place. Noversion.jsonappears anywhere in the history (git log --all -- version.jsonis empty). Thenbgvtool listed in.config/dotnet-tools.jsonis not run by any workflow; Dependabot has been bumping it all the same (#57, #132, #194).Every release so far has used a hand-set
<Version>inDirectory.Build.props, checked by two jobs. Inrelease.yml,guardfails unless the tag equals<Version>and the CHANGELOG has a section for that version. Inpr.yml,version / CHANGELOG syncfails unless the current<Version>has such a section. §8 now describes that, along with what a release pull request changes, and the Consequences bullet that credited NBGV now credits the checks.The unused
nbgventry stays in the tool manifest; removing it is a separate change.