Repository navigation
fix(release): name a prerelease package the way GitHub serves it - #26
Merged
Merged
Conversation
GitHub turns the "~" of 0.3.0~rc.1 into "." in an asset's name, so SHA256SUMS listed two files the rc.1 release did not have. Shell scripts keep LF endings so they run from a Windows checkout in WSL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub turns a
~in a release asset's name into., so thev0.3.0-rc.1release servedgitreant_0.3.0.rc.1-1_amd64.debwhile itsSHA256SUMSlistedgitreant_0.3.0~rc.1-1_amd64.deb, andsha256sum -ccould not find either package.build-deb.shnow writes the file under the name the release will serve. The package'sVersionkeeps the~, which is what sorts an rc before its release. A stable version has no~, so its file names do not change.The shell scripts are checked out with LF endings, so a Windows checkout runs them in WSL; with CRLF, bash stops at
set -o pipefail.ADR 0034 also records that the install test runs in a job that can only read the repository, which stays true if the test moves into an action kept in ShortArrow/pkg.