Repository navigation
feat(ui): collapse submodule graphs, fade unreachable rows, align submodule nodes - #24
Merged
Merged
Conversation
Their commit menu offers no tag or branch, which would land in another repository, and the nodes now draw above the dashed links that covered them.
The rows lose width to every submodule's graph; a collapsed one keeps only its name, and the choice is kept per repository (#18).
Following one branch through a busy graph meant reading every row (#17).
…e robust A reload under a hovered badge left rows faded, a link to the newest commit covered half the collapse button, the strip's name spilled past it, and a corrupted stored value stopped the collapse from being saved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17. Closes #18.
A submodule graph's nodes now answer hover and right-click the way the main graph's do. The menu offers the commit id and, through
commit_url_base, the web page on the submodule's own origin, but not tag or branch creation, which act on the superproject. The nodes are drawn above the dashed pointer links, so a link's hit area no longer swallows the node it ends on.Collapsing applies to submodule regions only; the main graph always stays. A collapsed region keeps a 16px strip with its name, its pointer links are dropped, and the choice is stored per repository in the browser's
localStorage(collapsedSubmodulesIn), where an unreadable value counts as nothing collapsed. The collapse toggle sits above the first row, outside every link's hit area.The fade walks parent links through the loaded commits (
reachableFrom). It starts on a branch badge's hover and ends on leave or when the commit list reloads, since a reload can move the badge away from under the pointer.