Repository navigation
feat(ui): make "Diff all" a toggle - #20
Merged
Merged
Conversation
Pressed again it closes the diff, so opening and closing no longer means reaching for the pane's close button (#19).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19.
"Diff all" now closes the diff when every file's diff is already open, so opening and closing it happens from one button. While a single file's diff is open, the button still switches to every file's diff instead of closing it.
The button is no longer idempotent: a second press undoes the first. Its pressed state shows through the existing
activeclass ofLabeledButton.Accessibility
LabeledButtonnow setsaria-pressedfromactive, so every toggle that uses it is announced as one: the log, info and settings buttons, the file list's flat and tree views, the diff's inline and split views, and the log's wrap. A button that never passesactivegets noaria-pressed, as before.