Skip to content

Fix previous deploy links to use type-specific pages #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efegokdemir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix previous deploy links to use type-specific pages #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/shipit/stacks/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<h2>Previous Deploys</h2>
</header>
<ul class="commit-list">
<%= render partial: 'shipit/tasks/task', collection: @tasks %>
<%= render partial: @tasks %>
</ul>
</section>
<% end %>
Expand Down
9 changes: 9 additions & 0 deletions test/controllers/stacks_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,15 @@ class StacksControllerTest < ActionController::TestCase
assert_response :ok
end

test "#show links deploys, rollbacks, and tasks to their own pages" do
get :show, params: { id: @stack.to_param }

assert_response :ok
assert_select ".commit-list a[href='#{stack_deploy_path(@stack, shipit_tasks(:shipit))}']"
assert_select ".commit-list a[href='#{stack_deploy_path(@stack, shipit_tasks(:shipit_rollback))}']"
assert_select ".commit-list a[href='#{stack_task_path(@stack, shipit_tasks(:shipit_restart))}']"
end

test "#show with faulty and validating deploys is success" do
get :show, params: { id: shipit_stacks(:shipit_canaries).to_param }
assert_response :ok
Expand Down
Loading