Repository navigation
0.45.5 - #1509
Merged
Merged
0.45.5#1509
Conversation
…cks fail When a deployment check fails (e.g. Shopify's Infra Central global deploy lock), Stack#trigger_continuous_delivery marks continuous delivery as delayed. The banners partial checked continuous_delivery_delayed? first and only rendered the external-lock banner in the elsif branch, so the lock banner was never shown on CD stacks and users saw a misleading 'pre-deploy checks failed' message instead. Check deployment_checks_passed? first so the lock banner, with its message, takes precedence. Co-authored-by: Timothy Smith <tim.smith@shopify.com>
gerryhuynh
approved these changes
Oct 21, 2026
timothysmith0609
force-pushed
the
ts/0.45.5
branch
from
October 22, 2026 15:27
8ab83f2 to
50f4283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the global lock is active we are accidentally showing the
Continous Delivery Disabledinstead of the actualDeploys lockedbanner. This is confusing and fails to surface the actual lock message.