fix(🤖): ship consumer proguard rules - #4033
Open
bigcupcoffee wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes React Native Skia ship its consumer Proguard rules as part of the Android library artifact, so app consumers no longer need to manually copy keep rules into their own proguard-rules.pro.
Changes:
- Add an Android library consumer Proguard rule to keep
com.shopify.reactnative.skia.**classes. - Configure the Android library module to publish/apply that rule automatically via
consumerProguardFiles. - Remove the now-unnecessary “Proguard” setup step from the installation docs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/skia/android/proguard-rules.pro | Adds the consumer Proguard keep rule for Skia classes. |
| packages/skia/android/build.gradle | Registers the consumer Proguard rules file for the library artifact. |
| apps/docs/docs/getting-started/installation.md | Removes manual Proguard configuration instructions that are now automated. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wcandillon
approved these changes
Aug 30, 2026
wcandillon
left a comment
wcandillon
left a comment
Contributor
There was a problem hiding this comment.
That's great thank you. Can you please sign the CLA?
The `files` whitelist enumerates the Android files individually, so `android/proguard-rules.pro` was excluded from the published tarball while build.gradle referenced it via consumerProguardFiles. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Hey, I'd rather not, feel free to close & commit it under your name 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shipping consumer proguard rules applies them automatically, not requiring addition of those rules in the app consuming the library