Skip to content

fix(example): preserve Twitter pages across asynchronous callbacks #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(example): preserve Twitter pages across asynchronous callbacks #2481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 35 additions & 12 deletions fixture/react-native/src/twitter/Twitter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useContext, useRef, useState } from "react";
import React, { useContext, useEffect, useRef, useState } from "react";
import {
View,
Text,
Expand All @@ -8,7 +8,7 @@ import {
} from "react-native";
import { FlashList, FlashListRef } from "@shopify/flash-list";

import { DebugContext } from "../Debug";
import { DebugContext } from "../Debug/DebugContext";

import TweetCell from "./TweetCell";
import { tweets as tweetsData } from "./data/tweets";
Expand All @@ -27,9 +27,22 @@ const Twitter = ({
}: TwitterProps) => {
const debugContext = useContext(DebugContext);
const [refreshing, setRefreshing] = useState(false);
const remainingTweets = useRef([...tweetsData].splice(10, tweetsData.length));
const [tweets, setTweets] = useState(
debugContext.pagingEnabled ? [...tweetsData].splice(0, 10) : tweetsData
const nextTweetIndex = useRef(
debugContext.pagingEnabled ? 10 : tweetsData.length
);
const refreshTimeout = useRef<ReturnType<typeof setTimeout> | null>(null);
const pageTimeout = useRef<ReturnType<typeof setTimeout> | null>(null);
const [tweets, setTweets] = useState(() =>
debugContext.pagingEnabled ? tweetsData.slice(0, 10) : tweetsData
);
useEffect(
() => () => {
if (refreshTimeout.current !== null) clearTimeout(refreshTimeout.current);
if (pageTimeout.current !== null) clearTimeout(pageTimeout.current);
refreshTimeout.current = null;
pageTimeout.current = null;
},
[]
);
const viewabilityConfig = useRef<ViewabilityConfig>({
waitForInteraction: false,
Expand All @@ -50,22 +63,32 @@ const Twitter = ({
}}
refreshing={refreshing}
onRefresh={() => {
if (refreshTimeout.current !== null) return;
setRefreshing(true);
setTimeout(() => {
refreshTimeout.current = setTimeout(() => {
refreshTimeout.current = null;
setRefreshing(false);
const reversedTweets = [...tweets];
reversedTweets.reverse();
setTweets(reversedTweets);
setTweets((previous) => [...previous].reverse());
}, 500);
}}
// @ts-ignore - Type compatibility issue between different React versions
CellRendererComponent={CellRendererComponent}
onEndReached={() => {
if (!debugContext.pagingEnabled) {
if (
!debugContext.pagingEnabled ||
pageTimeout.current !== null ||
nextTweetIndex.current >= tweetsData.length
) {
return;
}
setTimeout(() => {
setTweets([...tweets, ...remainingTweets.current.splice(0, 10)]);
pageTimeout.current = setTimeout(() => {
pageTimeout.current = null;
const page = tweetsData.slice(
nextTweetIndex.current,
nextTweetIndex.current + 10
);
nextTweetIndex.current += page.length;
setTweets((previous) => [...previous, ...page]);
}, 1000);
}}
ListHeaderComponent={Header}
Expand Down
Loading