Skip to content

Refer to app security checks generically instead of "App Security" - #8765

Merged
nickwesselman merged 1 commit into
mainfrom
app-security-generic-wording
Oct 5, 2026
Merged

nickwesselman merged 1 commit into
mainfrom
app-security-generic-wording

Conversation

@nickwesselman

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The shopify app security commands, their messages and the agent instructions call the feature "App Security", in title case, as if it were a product name. It should be described generically as an app security check.

WHAT is this pull request doing?

Replaces every title-cased "App Security" outside CHANGELOGs with generic wording, mostly "app security check", "app security check results" and "app security check instructions". The replacements were written phrase by phrase so sentences still read naturally. For example:

Before After
Runs Shopify App Security locally… Runs an app security check locally…
Remove local App Security results. Remove local app security check results.
Record agent App Security findings. Record agent findings from an app security check.
No App Security results for shopify.app in … No app security check results for shopify.app in …
App Security is Shopify's local security review workflow… App Security lives in Shopify CLI… The app security check is Shopify's local security review workflow… It lives in Shopify CLI…
App Security is distinct from an App Store review An app security check is distinct from an App Store review

Covered:

  • Command summaries and descriptions (check, clean, instructions, record, review)
  • Error, confirmation and headline messages, with the tests that assert them
  • The agent workflow (INSTRUCTIONS.md) and the EOL_API_VERSION check prompt
  • Code comments, debug output and test names

Regenerated: checks/embedded.ts (via embed-checks.mjs) and oclif.manifest.json. The README and docs are unchanged because the commands are still hidden on main.

"App Store", the product name, is unchanged. "App Security" still appears in CHANGELOGs, which record history.

How to manually test your changes?

  1. Run shopify app security check --yes on an app. The summary box and the printed agent instructions should say "app security check", never "App Security".
  2. Run shopify app security review before running check. It should say "No app security check results to review."

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows): text only.
  • I've considered possible documentation changes: docs are regenerated from the commands; there's nothing to publish while they're hidden.
  • I've considered analytics changes to measure impact: none needed.
  • The change is user-facing. I've identified the correct bump type (patch) and added a changeset.

🤖 Generated with Claude Code

@nickwesselman
nickwesselman requested review from a team as code owners October 5, 2026 21:34
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Oct 5, 2026
@nickwesselman nickwesselman mentioned this pull request Oct 5, 2026
1 of 4 tasks
@nickwesselman
nickwesselman added this pull request to the merge queue Oct 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 5, 2026
Replace the title-cased "App Security" product name in command help,
messages, agent instructions, check prompts, comments, and tests with
generic wording: "app security check" and "app security check results".
Regenerates the embedded checks, oclif manifest, and docs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@nickwesselman
nickwesselman force-pushed the app-security-generic-wording branch from 639712e to ebd7430 Compare October 5, 2026 22:08
@nickwesselman
nickwesselman added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 43fd485 Oct 5, 2026
30 checks passed
@nickwesselman
nickwesselman deleted the app-security-generic-wording branch October 5, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants