Repository navigation
App Security: lead the instructions question with the agent check count - #8759
Merged
Merged
Conversation
jek
added this pull request to stack #8741
October 5, 2026 14:58
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @jek! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261005151400Caution After installing, validate the version by running |
dmerand
approved these changes
Oct 5, 2026
jek
force-pushed
the
app-doctor/instructions-handoff
branch
from
October 5, 2026 17:41
4eb63f3 to
8c634a9
Compare
Contributor
|
| Command | Flag |
|---|---|
app:security:check |
--ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/24069
After
check, the question "How would you like to hand the results to your coding agent?" didn't say that the scan isn't complete until the agent runs its checks.WHAT is this pull request doing?
Before
After
How to manually test your changes?
pnpm shopify app security check --path <app directory>in an interactive terminal, and check the report and the question.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add