Skip to content

App Security: lead the instructions question with the agent check count - #8759

Merged
jek merged 1 commit into
app-security/agent-workflowfrom
app-doctor/instructions-handoff
Oct 5, 2026
Merged

jek merged 1 commit into
app-security/agent-workflowfrom
app-doctor/instructions-handoff

Conversation

@jek

@jek jek commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes https://github.com/shop/issues-develop/issues/24069

After check, the question "How would you like to hand the results to your coding agent?" didn't say that the scan isn't complete until the agent runs its checks.

WHAT is this pull request doing?

  • The question leads with the work left: " recommended agent checks available to complete your scan. How do you want to pass that prompt to your agent?"
  • Next step 1 is now "Have your coding agent run the agent checks". It no longer repeats the agent checks path, which Artifacts already shows.
  • Artifacts renames "Agent checks" to "Agent security check instructions", and shows both paths relative to the app directory, like the scan directories and issue locations.

Before

Google Chrome - Shopify - Calendar - Week of October 5, 2026 202

After

Google Chrome - Shopify - Calendar - Week of October 5, 2026 202 (2)

How to manually test your changes?

  • pnpm shopify app security check --path <app directory> in an interactive terminal, and check the report and the question.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@jek
jek requested a review from a team as a code owner October 5, 2026 14:58
@jek
jek added this pull request to stack #8741 October 5, 2026 14:58
@jek jek changed the title Lead the instructions question with the agent check count App Security: lead the instructions question with the agent check count Oct 5, 2026
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Oct 5, 2026
@jek
jek requested a review from jplhomer October 5, 2026 15:00
@jek

jek commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @jek! Your snapshot has been published to npm.

Built from 4eb63f38da8d08e037c0f18120c4bfaef0efaa57. Workflow run.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261005151400

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@jplhomer jplhomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jek
jek force-pushed the app-doctor/instructions-handoff branch from 4eb63f3 to 8c634a9 Compare October 5, 2026 17:41
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release.

🏳️ Removed Flags

The following flags were removed from existing commands:

Command Flag
app:security:check --ignore

@jek
jek added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 4f9a680 Oct 5, 2026
29 of 30 checks passed
@jek
jek deleted the app-doctor/instructions-handoff branch October 5, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants