Polish App Security record and review from stack review feedback - #8732
Merged
Merged
Conversation
dmerand
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Follow-ups agreed in review of #8692 and #8693.
WHAT is this pull request doing?
recordvalidation errors. Errors quote agent input (check IDs, paths, line values), and a secret there reached the terminal and--jsonoutput. The engine now redacts them the same way it redacts stored findings.reviewcan't read. Check snapshots and indentation make the storedagent-findings.jsonbigger than the input, so an input under 5 MB could be stored over 5 MB, whichreviewrejects.recordnow checks the stored size first and rejects the document without replacing the existing file.app/café.tswas recorded wrong. The command now usesGet-Content -Raw -Encoding UTF8. The$OutputEncodingnote now follows both PowerShell forms, since both pipe text torecord. A Windows-only test runs the command throughpowershell.exe.--verbose. Suppressed and superseded findings of unresolved checks are now listed in full, as they already are for passed checks.How to manually test your changes?
Redacted validation errors. Only
recordis involved; the document is rejected, so nothing is written.Expect the error to show
shpa[REDACTED:38]instead of the token, in bothcustomSectionsanddetails.errors.Unresolved check details. Record an unresolved check with a suppressed finding, then review it:
Without
--verbose, the unresolved box shows the status and1 finding suppressed. With--verbose, it also lists the finding: its message, reasoning, evidence and suppression justification.PowerShell encoding. On Windows PowerShell 5.1, save a findings document as UTF-8 without a byte order mark, with a finding in
app/café.ts. Pipe it torecordusing the command fromshopify app security instructions, then runreview. Expect the path to show asapp/café.ts.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add