[Tests] Cover the bulk operations status table formatting - #8715
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
The text-mode table rendered by `renderBulkOperationStatusResult` had no direct coverage: the count abbreviation thresholds, the ID shortening, the date columns, and the results-link fallback were never asserted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Reviewing Main tests runs from 2026-09-24T00:32Z to 2026-10-01T00:32Z found ten failed runs, but no actionable flake left to fix:
src/cli/commands/version.test.tssubprocess timeouts accounted for nine of the ten (windows Node 22, windows Node 24, macos Node 22). Open PR Stabilize version, profile, and package cache tests #8669 already replaces thosets-nodesubprocesses with in-process capture, so fixing it here would duplicate that work.conf-store.test.ts > runs the task as usual when the cache is populated but outdated(ubuntu Node 26), ran onstable/4.8and is already fixed onmainby merged PR [Tests] Fix flaky outdated rate-limit cache test #8705.No run in the window had an earlier failed attempt, so with the flake list exhausted this closes a coverage gap instead.
The text-mode table in
status-result.ts(added in #8568) had no direct coverage.renderBulkOperationStatusResultwas only exercised for JSON output and the not-found error, leaving the count abbreviation thresholds, the operation ID shortening, the date columns, and the download-link fallback unasserted.WHAT is this pull request doing?
Adds four tests to
result.test.tscovering the table rows thatshopify store bulk statusrenders without an--id:999999case that formats as1000.0K.urltopartialDataUrl, with an empty finished date while the operation is unfinished.Assertions use
expect.objectContainingon therenderTablerows so each test pins only the cells it is about, leaving column styling free to change.Validation on Linux x86_64 / Node 26.1.0: all 64 store test files pass, plus lint and type-check. Shuffled ordering (
--sequence.shuffle) passed five consecutive runs, and theforkspool passed. Reverting each behaviour under test fails the matching assertion, confirming the tests would catch a regression.The originally failing Windows and macOS runners are not reproducible locally, so cross-platform behaviour is confirmed only by CI on this PR. These tests assert pure string formatting and mock the UI layer, so they carry no platform-specific timing or filesystem dependency.
How to manually test your changes?
Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add