Extract App Security checks behind a replaceable package contract - #8714
Draft
nickwesselman wants to merge 1 commit into
Draft
nickwesselman wants to merge 1 commit into
nickwesselman wants to merge 1 commit into
Conversation
…ge contract Co-authored-by: Qlaw <noreply@qlaw.quick.shopify.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Prove that App Security checks can be amended or replaced by another compatible package without replacing
shopify app security checkor its review/findings workflow.WHAT is this pull request doing?
Consume the check set extracted in the paired package PR. Keep discovery, capability detection, scheduling, review-pack generation, findings validation/merge, trace compilation, redaction enforcement, artifacts, command UX and uploads in CLI.
Thread the selected check set explicitly through the existing engine;
createAppSecurityEngine(checkSet)binds an alternative set without global mutation. The integration fixture exercises a complete replacement through scan, review, registry, findings compilation and trace. Default detector code and prompt bytes are preserved in the package.Draft POC only: dependency uses a local
.poc/app-security-checkslink. Public CI cannot install it without the documented local checkout/build. No npm publishing or production dependency is introduced; resolve distribution/versioning before merging. See local setup and boundary.How to manually test your changes?
Follow the linked local setup, then run against a Shopify app:
Validation
Checklist
PR authored by Qlaw