Skip to content

Avoid duplicate app lookups for Function schemas - #8707

Draft
dmerand wants to merge 1 commit into
mainfrom
donald/functions-schema-known-app-id
Draft

dmerand wants to merge 1 commit into
mainfrom
donald/functions-schema-known-app-id

Conversation

@dmerand

@dmerand dmerand commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Function schema generation already has the app ID from linked app context. The client looks up the app again only to recover that same ID.

WHAT is this pull request doing?

Pass the resolved app ID through schema generation and request the schema directly from Functions. This removes one duplicate App Management lookup per fetched schema, for either target-based or API-type queries. It does not remove initial context or access checks.

Keep the numeric Functions URL, schema contents and version header, stdout/file behavior, and existing-schema fast path unchanged.

Use the PR snapshot from a linked Function directory for the manual commands below. Check both target-based and API-type configurations.

How to manually test your changes?

shopify app function schema --stdout
shopify app function schema

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Sep 30, 2026
@dmerand
dmerand added this pull request to stack #8712 September 30, 2026 14:28
@dmerand
dmerand force-pushed the donald/functions-schema-known-app-id branch from 6cb5a0a to 2dcd9eb Compare September 30, 2026 18:41
@dmerand
dmerand removed this pull request from stack #8712 September 30, 2026 18:43
@dmerand
dmerand changed the base branch from donald/app-api-client-id to main September 30, 2026 18:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant