Add typed JSON output to theme init - #8684
Open
gonzaloriestra wants to merge 1 commit into
Open
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
gonzaloriestra
added this pull request to stack #8673
September 28, 2026 09:53
gonzaloriestra
marked this pull request as ready for review
September 28, 2026 10:17
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
September 28, 2026 11:39
15928b5 to
af38492
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
September 29, 2026 10:28
9c90616 to
a0861a7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
September 29, 2026 11:11
a0861a7 to
8b17788
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
2 times, most recently
from
September 29, 2026 13:44
1742d91 to
eced348
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
September 29, 2026 14:18
eced348 to
a5f5c9b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
September 29, 2026 14:40
a5f5c9b to
74e4949
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-init
branch
from
October 1, 2026 08:52
74e4949 to
2c8e408
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme initclones a theme and optionally creates AI instructions without returning a typed result for scripts.Part of shop/issues-develop#23694.
WHAT is this pull request doing?
Expose the destination, repository, latest-release option, selected AI instructions, and instruction file paths as JSON. Keep the existing prompts and cleanup behavior, report task progress and copy-fallback warnings on stderr, and emit the result only after setup completes.
Fix the existing
--latestclone failure by disabling shallow cloning when fetching release tags.Normal output:
Matching JSON example when AI setup is skipped:
{ "path": "/themes/example", "repoUrl": "https://github.com/Shopify/skeleton-theme.git", "latest": false, "aiInstructions": null, "instructionFiles": [] }How to manually test your changes?
Checklist