Add typed JSON output to theme package - #8683
Open
gonzaloriestra wants to merge 1 commit into
Open
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
gonzaloriestra
added this pull request to stack #8673
September 28, 2026 09:53
gonzaloriestra
marked this pull request as ready for review
September 28, 2026 09:57
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
September 28, 2026 10:25
9dce70c to
cbf4e74
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
September 28, 2026 11:39
cbf4e74 to
8290b55
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
September 28, 2026 11:52
8290b55 to
195f2b0
Compare
isaacroldan
reviewed
Sep 29, 2026
| vi.mock('@shopify/cli-kit/node/analytics', () => ({ | ||
| recordEvent: vi.fn(), | ||
| compileData: vi.fn().mockReturnValue({timings: {}, errors: {}, retries: {}, events: {}}), | ||
| })) |
Contributor
There was a problem hiding this comment.
you don't need these special cases no? Just
vi.mock('@shopify/cli-kit/node/ui')
vi.mock('@shopify/cli-kit/node/analytics')
Should work fine
Contributor
Author
There was a problem hiding this comment.
Updated, thanks
isaacroldan
approved these changes
Sep 29, 2026
isaacroldan
left a comment
Contributor
There was a problem hiding this comment.
Minor comment on the tests
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
September 29, 2026 10:28
195f2b0 to
28d575f
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
September 29, 2026 11:11
28d575f to
29801b7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
2 times, most recently
from
September 29, 2026 13:44
5f102b2 to
72d4123
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
2 times, most recently
from
September 29, 2026 14:40
3d1d2b9 to
901c0bc
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-package
branch
from
October 1, 2026 08:52
901c0bc to
d5ad578
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme packagecreates a ZIP file but has no machine-readable result or discoverable output schema.Part of shop/issues-develop#23694.
WHAT is this pull request doing?
Return the ZIP path from packaging and present it as text or validated JSON. Keep the existing archive contents, filename rules, errors, and success message.
Normal output:
Matching JSON example:
{"path": "/themes/example/Dawn-1.0.zip"}How to manually test your changes?
Checklist