Skip to content

Expose module identity to reverse configuration transforms - #8674

Closed
dpeacock wants to merge 1 commit into
mainfrom
dp-module-transform-context
Closed

dpeacock wants to merge 1 commit into
mainfrom
dp-module-transform-context

Conversation

@dpeacock

@dpeacock dpeacock commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

When the CLI converts a module's configuration back to local app config, the configuration alone may not contain the module's identity. Today the transform receives flags, but not the module handle that both callers already know.

WHAT is this pull request doing?

Pass an optional, readonly module handle to reverse configuration transforms from both places that call them:

  • remote modules use the handle returned by Shopify
  • local modules use the extension handle being deployed

Existing transforms can ignore the new context, so this does not change current module behavior. It provides a small shared capability that module-specific code can adopt without adding special cases to generic callers.

This PR contains no Events-specific behavior and does not change payload schemas or make additional requests.

Validation

A synthetic configuration module verifies that both callers receive the correct handle and continue producing an unchanged config. The full app suite, package type-check, and lint pass.

No changeset is included because this is an internal framework capability with no user-facing behavior on its own.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Sep 25, 2026
Pass optional readonly module identity through the existing reverse
transform options in both remote reconstruction and local deploy
comparison. Specifications can use envelope identity without adding
feature-specific branches to generic callers.

Keep this framework capability independent of Events adoption. A synthetic
specification verifies both identity sources and unchanged config output;
existing transforms do not need to consume the new context.
@dpeacock
dpeacock force-pushed the dp-module-transform-context branch from 935bbd0 to 54e984d Compare September 25, 2026 16:53
@dpeacock
dpeacock changed the base branch from events-subscription-fanout to main September 25, 2026 16:53
@github-actions github-actions Bot added Area: @shopify/cli @shopify/cli package issues and removed no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. labels Sep 25, 2026
@Shopify Shopify deleted a comment from github-actions Bot Sep 25, 2026
@dpeacock dpeacock closed this Sep 25, 2026
@dpeacock dpeacock reopened this Sep 25, 2026
@github-actions github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/cli @shopify/cli package issues labels Sep 25, 2026
@dpeacock dpeacock closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant