Add typed JSON output to theme publish - #8652
Open
gonzaloriestra wants to merge 1 commit into
Open
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
gonzaloriestra
added this pull request to stack #8654
September 24, 2026 09:47
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 10:04
d3213d0 to
789a14a
Compare
gonzaloriestra
removed this pull request from stack #8654
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 10:13
789a14a to
bcdcb7d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 10:25
bcdcb7d to
56a75f3
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 11:56
56a75f3 to
15a4930
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
2 times, most recently
from
September 24, 2026 14:21
0adfd99 to
5ba599e
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:34
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 24, 2026 14:36
5ba599e to
51ec362
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 25, 2026 12:28
51ec362 to
46ed754
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 28, 2026 08:20
46ed754 to
f8d5e61
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
2 times, most recently
from
September 28, 2026 11:39
493c1ea to
97fc0af
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 28, 2026 11:51
97fc0af to
2c18dfa
Compare
isaacroldan
approved these changes
Sep 29, 2026
isaacroldan
approved these changes
Sep 29, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 29, 2026 10:28
2c18dfa to
bc376f7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 29, 2026 11:11
bc376f7 to
aa1b9ca
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
2 times, most recently
from
September 29, 2026 13:44
cfc35a6 to
7699b97
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 29, 2026 14:18
7699b97 to
9921794
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
September 29, 2026 14:40
9921794 to
2a1064f
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-publish
branch
from
October 1, 2026 08:52
2a1064f to
065a1ec
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme publishhas no JSON result contract, so automation must parse terminal output.Part of shop/issues-develop#23692.
WHAT is this pull request doing?
Return
status: "success"alongside the published theme, using the shared mutation success schema. Multiple environments carry the status inside each successful result, with no overall success claim.Return the published API theme as typed data and move final output into a presenter. Reuse the environment collector from the preceding PR, retaining prompts and the original terminal wording. Add
--json, expose the domain-owned schema, and refresh the manifest, README, and generated docs.Normal output includes:
Matching JSON:
{ "status": "success", "theme": { "id": 1, "name": "Original", "role": "live", "processing": false, "createdAtRuntime": false, "shop": "example.myshopify.com" } }The optional
srcfield is retained when present. Multiple environments return{"environments":[{"environment":"staging","result":...}]}in configured order. Failed or invalid environments are omitted and reported on stderr; total failure returns{"environments":[]}. Existing exit behavior and single-environment presentation are preserved.How to manually test your changes?
Checklist