Add typed JSON output to theme list - #8641
Open
gonzaloriestra wants to merge 1 commit into
Open
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
gonzaloriestra
added this pull request to stack #8644
September 24, 2026 09:19
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 24, 2026 10:04
095fe47 to
fd69066
Compare
gonzaloriestra
removed this pull request from stack #8644
September 24, 2026 10:04
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 24, 2026 10:25
479bc56 to
bfe48a7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 24, 2026 11:56
bfe48a7 to
3b51bcf
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:13
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 25, 2026 12:28
1ced35d to
fb8ea3a
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 28, 2026 10:25
964ae97 to
69e125b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 28, 2026 11:39
69e125b to
b5ce60d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 29, 2026 10:28
49c6245 to
696f8e2
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 29, 2026 11:11
696f8e2 to
9264426
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
2 times, most recently
from
September 29, 2026 14:18
05a956c to
aa4252a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
September 29, 2026 14:40
aa4252a to
c2de27e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-list
branch
from
October 1, 2026 08:52
c2de27e to
a9efff4
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme list --jsonhas an existing result shape but no discoverable schema.Related to shop/issues-develop#23691. Stacked on #8525.
WHAT is this pull request doing?
Return typed theme data and expose its schema. Keep the existing single-environment JSON and table output. Multiple environments emit one
{environments: [{environment, result}]}document in requested order; failed environments report errors on stderr and are omitted, with existing exit behavior preserved.Normal output:
Matching JSON:
[{"id":1,"name":"Dawn","processing":false,"createdAtRuntime":false,"role":"live"}]Adds the opt-in result collection boundary in
ThemeCommand, with results recorded after analytics cleanup. Refreshes generated help and the manifest.How to manually test your changes?
Checklist