Repository navigation
Normalize subscription migration status JSON - #8588
Merged
gonzaloriestra merged 3 commits intoOct 9, 2026
Merged
gonzaloriestra merged 3 commits into
gonzaloriestra merged 3 commits into
Conversation
4 tasks done
gonzaloriestra
added this pull request to stack #8590
September 18, 2026 12:23
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
September 21, 2026 12:17
d7f9d35 to
366dfec
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
2 times, most recently
from
September 22, 2026 12:24
c53a9f9 to
bdfadaf
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
September 24, 2026 10:32
bdfadaf to
ff24d54
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
September 24, 2026 10:41
ff24d54 to
146a02c
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 10:46
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:00
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
October 6, 2026 12:05
146a02c to
9c7cec8
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
October 6, 2026 12:26
9c7cec8 to
d6e4ef8
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 08:57
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
October 8, 2026 11:40
d6e4ef8 to
ecacc02
Compare
isaacroldan
approved these changes
Oct 8, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
October 9, 2026 07:45
ecacc02 to
ccb05c4
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
October 9, 2026 08:12
ccb05c4 to
40a0962
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-status
branch
from
October 9, 2026 08:37
40a0962 to
36447b4
Compare
Contributor
|
| Changeset | Package |
|---|---|
normalize-migration-status-json.md |
"@shopify/cli": major |
normalize-migration-submission-json.md |
"@shopify/cli": major |
normalize-migration-subscription-list-json.md |
"@shopify/cli": major |
normalize-subscription-migration-json.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/public/node/error/serialization.d.tsimport type { JsonError } from './types.js';
/**
* Projects an error into the shared JSON error contract, retaining only allowlisted fields.
*
* @param source - Error to project.
* @returns The error classification, message, and available recovery information.
*/
export declare function errorToJson(source: unknown): JsonError;
Existing type declarationspackages/cli-kit/dist/private/node/json-error.d.ts@@ -1,16 +1,3 @@
-interface FatalErrorLike {
- type?: number;
- message?: unknown;
- formattedMessage?: unknown;
- tryMessage?: unknown;
- nextSteps?: unknown;
- customSections?: unknown;
- stack?: unknown;
- command?: unknown;
- args?: unknown;
- details?: unknown;
- code?: unknown;
-}
/**
* Writes the public JSON representation of a fatal error to stdout.
*
@@ -19,5 +6,4 @@ interface FatalErrorLike {
*
* @param error - Fatal error to serialize.
*/
-export declare function renderFatalErrorAsJson(error: FatalErrorLike): void;
-export {};
\ No newline at end of file
+export declare function renderFatalErrorAsJson(error: unknown): void;
\ No newline at end of file
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Subscription migration JSON must follow the shared CLI conventions and expose a discoverable contract.
WHAT is this pull request doing?
Use
gid/shopGidand flat per-shop results. Validate strict resource projections while keeping upstream states extensible, with one stdout document and watch progress on stderr. RemoveschemaVersion; result contracts follow CLI release versions. Update the schema, tests, and generated help together. These existing JSON contract changes include a major changeset.How to manually test your changes?
Checklist