Skip to content

Recognize GitLab CI dependency auditing in App Doctor - #8558

Closed
jplhomer wants to merge 1 commit into
joshlarson/app-doctor-dependency-auditingfrom
joshlarson/app-doctor-dependency-auditing-gitlab
Closed

jplhomer wants to merge 1 commit into
joshlarson/app-doctor-dependency-auditingfrom
joshlarson/app-doctor-dependency-auditing-gitlab

Conversation

@jplhomer

@jplhomer jplhomer commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The dependency-auditing check introduced in #8556 should also recognize auditing configured in GitLab CI.

WHAT is this pull request doing?

Extends the existing check to inspect .gitlab-ci.yml for dependency-scanning templates and scanner invocations in executable jobs. Reuses the shared discovery safety checks and bounded command analysis without executing CI commands or making network requests.

Uses GitLab-specific Zod schemas for inspected configuration and selected scripts, preserving disabled-job and inherited-script boundaries. Includes recognition, discovery, and validation-boundary tests. Unsupported includes and inheritance remain unresolved unless separate recognized evidence covers the app.

How to manually test your changes?

pnpm shopify app doctor --path /path/to/gitlab-ci-app --skip-instructions
pnpm shopify app doctor --path /path/to/gitlab-ci-app --json --blocking low

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type and added a changeset

@jplhomer
jplhomer added this pull request to stack #8557 September 15, 2026 18:24
@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Sep 15, 2026
Co-authored-by: AI (Pi/GPT-6 Astra) <noreply@pi.dev>
@jplhomer
jplhomer force-pushed the joshlarson/app-doctor-dependency-auditing-gitlab branch from 1fb437d to 4ca931c Compare September 15, 2026 19:02
@jplhomer

Copy link
Copy Markdown
Contributor Author

Superseded by the simplified file-presence check in #8556. We no longer inspect GitLab CI workflows or shell commands; standard Dependabot/Renovate configuration filenames are sufficient. The branch is retained for reference.

@jplhomer jplhomer closed this Sep 15, 2026
An error occurred while trying to automatically change base from joshlarson/app-doctor-dependency-auditing to main September 17, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant