Remove the dependency CVE audit check from app doctor - #8555
Merged
Merged
Conversation
Co-authored-by: AI (Pi/GPT-6 Astra) <noreply@pi.dev>
dmerand
reviewed
Sep 16, 2026
| } | ||
| if ( | ||
| ['source', 'app_source', 'theme', 'manifest', 'secrets', 'source_and_theme'].includes(definition.target) && | ||
| ['source', 'app_source', 'theme', 'secrets', 'source_and_theme'].includes(definition.target) && |
Contributor
There was a problem hiding this comment.
I'm glad for this cleanup, the references to manifest and audit look like potential inconsistency debt from fast iteration?
Contributor
Author
There was a problem hiding this comment.
I think audit (CVE audit) used manifest as a target (package lockfile) so this was a legit removal 👍
dmerand
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
https://github.com/shop/issues-develop/issues/23910
CVE auditing is tricky. Previous support was pinned to just NPM dependencies, and even within those, false positives were detected for dependencies used only in development or tests.
npm auditalso calls out to the public internet which makes it a little iffy as far as exposing private package names to third parties.This PR removes App Doctor's package-manager CVE audit while a replacement is developed in a future PR.
WHAT is this pull request doing?
Removes the CVE audit runner, check registration, fallback prompt, and related tests. Cleans up command help and generated metadata, preserves submission coverage using an existing check, and adds a removal changeset. No replacement or absence tests are added.
How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add