[Refactor] Simplify severity counting in countOffenseTypes - #8552
Merged
Merged
Conversation
Replace the hasOwnProperty pre-initialization with nullish coalescing, matching the counting idiom used elsewhere in the repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Suleimanlatrsh
approved these changes
Sep 15, 2026
Suleimanlatrsh
left a comment
Suleimanlatrsh
left a comment
There was a problem hiding this comment.
Tested locally, including repeated severities and the text/JSON output. Looks good 👍
gonzaloriestra
marked this pull request as ready for review
September 16, 2026 08:56
github-actions
Bot
added
the
no-changelog
gonzaloriestra
approved these changes
Sep 16, 2026
gonzaloriestra
enabled auto-merge
September 16, 2026 08:57
EvilGenius13
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
countOffenseTypesinpackages/theme/src/cli/services/check.tscounted offenses per severity in three steps: anObject.prototype.hasOwnProperty.callprobe, an explicit= 0initialization, and a!-asserted increment. The non-null assertion was only safe because of the preceding initialization, so the reader has to follow all three lines to convince themselves the counter is sound.WHAT is this pull request doing?
Collapse the accumulator update into a single nullish-coalescing expression, so the "start at zero, then add one" intent reads directly and the non-null assertion is no longer needed:
This matches the counting idiom already used elsewhere in the repo (for example
packages/plugin-did-you-mean/src/index.ts).Behavior is unchanged. The accumulator starts as
{}and only ever stores numbers, so no key is ever explicitly set toundefined— the?? 0branch is taken in exactly the cases where thehasOwnPropertyprobe previously returnedfalse.How to manually test your changes?
Run against a theme containing errors, warnings, and info-level offenses, and confirm the summary counts are unchanged. Also check the JSON shape:
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add