Skip to content

[Tests] Cover theme dev error page rendering and HTML escaping #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
Sep 16, 2026
Merged

[Tests] Cover theme dev error page rendering and HTML escaping #8551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions packages/theme/src/cli/utilities/theme-environment/hot-reload/error-page.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import {getErrorPage} from './error-page.js'
import {describe, expect, test} from 'vitest'

describe('getErrorPage', () => {
test('renders the title and header', () => {
const page = getErrorPage({title: 'Failed to render', header: 'Liquid syntax error', errors: []})

expect(page).toContain('<title>Failed to render</title>')
expect(page).toContain('Liquid syntax error')
})

test('renders the message and code of every error', () => {
const page = getErrorPage({
title: 'Failed to render',
header: 'Liquid syntax error',
errors: [
{message: 'Unknown tag', code: 'sections/header.liquid:12'},
{message: 'Unclosed block', code: 'sections/footer.liquid:3'},
],
})

expect(page).toContain('Unknown tag')
expect(page).toContain('sections/header.liquid:12')
expect(page).toContain('Unclosed block')
expect(page).toContain('sections/footer.liquid:3')
})

test('escapes HTML in error messages and codes so untrusted content cannot inject markup', () => {
const page = getErrorPage({
title: 'Failed to render',
header: 'Liquid syntax error',
errors: [{message: '<script>alert("xss")</script>', code: "it's <b>here</b> & broken"}],
})

expect(page).not.toContain('<script>alert')
expect(page).toContain('&lt;script&gt;alert(&quot;xss&quot;)&lt;/script&gt;')
expect(page).toContain('it&#039;s &lt;b&gt;here&lt;/b&gt; &amp; broken')
})

test('returns a complete document when there are no errors', () => {
const page = getErrorPage({title: 'Failed to render', header: 'Liquid syntax error', errors: []})

expect(page).toMatch(/^<!DOCTYPE html>/)
expect(page).toContain('</html>')
})
})
Loading