[Refactor] Use Set for alreadyPresentKeys in patchEnvFile - #8486
[Refactor] Use Set for alreadyPresentKeys in patchEnvFile#8486gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
In
patchEnvFile, key existence tracking previously usedalreadyPresentKeys: string[], performing array linear scans with.includes()for every variable patched in.env.WHAT is this pull request doing?
Refactored
alreadyPresentKeysinpatchEnvFile(packages/cli-kit/src/public/node/dot-env.ts) to use aSet<string>, replacing.push()with.add()and.includes()with.has(). This simplifies membership lookups while preserving exact behavior.How to test your changes?
CI
Post-release steps
N/A
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 10551597752176063295 started by @gonzaloriestra