[Security] Prevent option injection in removeGitRemote - #8483
[Security] Prevent option injection in removeGitRemote#8483gonzaloriestra wants to merge 1 commit into
Conversation
Validate remoteName parameter in removeGitRemote to ensure it does not start with a hyphen, preventing option injection attacks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
This change hardens
removeGitRemoteagainst argument and option injection vulnerabilities when removing Git remotes.WHAT is this pull request doing?
Validates that
remoteNamepassed toremoveGitRemotedoes not start with a hyphen (-). If it does, anAbortErroris thrown before calling git.How to test your changes?
CI
Post-release steps
None
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 3642178902839292857 started by @gonzaloriestra