Log store auth session decisions in theme commands under --verbose - #8186
Merged
Conversation
This was referenced Jul 28, 2026
Contributor
Author
1 task
alfonso-noriega
marked this pull request as ready for review
July 28, 2026 14:56
isaacroldan
approved these changes
Jul 28, 2026
graygilmore
approved these changes
Jul 28, 2026
EvilGenius13
approved these changes
Jul 28, 2026
Diagnosing why a theme command picked (or skipped) a stored store auth session previously required tracing the code: the session source was invisible in verbose output, which made support investigations slow. Emit debug lines when a stored session is adopted, skipped for missing scopes, or skipped as expired. Tokens are never logged. Assisted-By: devx/60503589-d48c-43b2-8fba-b0df1e076f15
alfonso-noriega
force-pushed
the
theme-store-auth-debug-logging
branch
from
July 29, 2026 09:33
23ade87 to
1fe2f2f
Compare
alfonso-noriega
force-pushed
the
theme-store-auth-skip-expired
branch
from
July 29, 2026 09:33
6abd257 to
7bb01a9
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/api/partners.d.ts@@ -1,5 +1,7 @@
import { GraphQLVariables, GraphQLResponse, CacheOptions, UnauthorizedHandler } from './graphql.js';
import { RequestModeInput } from '../http.js';
+import { Variables } from 'graphql-request';
+import { TypedDocumentNode } from '@graphql-typed-document-node/core';
/**
* Executes a GraphQL query against the Partners API.
*
@@ -12,6 +14,17 @@ import { RequestModeInput } from '../http.js';
* @returns The response of the query of generic type <T>.
*/
export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<T>;
+/**
+ * Executes a GraphQL query against the Partners API. Uses typed documents.
+ *
+ * @param query - GraphQL query to execute.
+ * @param token - Partners token.
+ * @param variables - GraphQL variables to pass to the query.
+ * @param preferredBehaviour - Preferred behaviour for the request.
+ * @param unauthorizedHandler - Optional handler for unauthorized requests.
+ * @returns The response of the query of generic type <TResult>.
+ */
+export declare function partnersRequestDoc<TResult, TVariables extends Variables>(query: TypedDocumentNode<TResult, TVariables>, token: string, variables?: TVariables, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<TResult>;
/**
* Sets the next deprecation date from [GraphQL response extensions](https://www.apollographql.com/docs/resources/graphql-glossary/#extensions)
* if `response.extensions.deprecations` objects contain a `supportedUntilDate` (ISO 8601-formatted string).
|
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @alfonso-noriega! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260729111116Caution After installing, validate the version by running |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Final layer of the
theme devstore-auth regression fix (Slack thread); stacked on #8185.Diagnosing why a theme command picked (or skipped) a stored
store authsession previously required tracing the code — the session source was invisible in--verboseoutput, which made the original support investigations slow (the wyzecom case took multiple support rounds to attribute to the store-auth cache).WHAT is this pull request doing?
outputDebuglines when a stored store-auth session is:No changeset: debug-only output, no user-facing behavior change.
How to test your changes?
shopify store auth --store <store> --scopes read_themes,write_themesshopify theme pull --store <store> --verbose— the debug output includesUsing stored store auth session for <store> (scopes: ...).Measuring impact