Skip to content

Bundle shopify-dev-tools with Shopify CLI - #8157

Closed
durga256 wants to merge 1 commit into
remove-shopify-dev-tools-experimentsfrom
bundle-shopify-dev-tools-with-cli
Closed

durga256 wants to merge 1 commit into
remove-shopify-dev-tools-experimentsfrom
bundle-shopify-dev-tools-with-cli

Conversation

@durga256

@durga256 durga256 commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

shopify-dev-tools is now owned by the CLI monorepo, but the public CLI package must not acquire a runtime dependency on the restricted Cloudsmith package. Like dev-mcp, the CLI should consume it only at build time and ship the runtime data its bundled validators need.

WHAT is this pull request doing?

  • Adds @shopify/shopify-dev-tools as a workspace dev dependency and builds it before the CLI bundle.
  • Lets the existing esbuild pipeline inline any imported dev-tools code instead of leaving a runtime package dependency.
  • Copies compressed schemas, the supported-version catalog, and compressed type assets into dist/data.
  • Excludes raw and internal-only API data from the public CLI bundle and removes stale copied data before rebuilding.
  • Adds focused coverage for the data-copy allowlist.

No changeset: this is internal packaging infrastructure with no CLI behavior change yet.

How to test your changes?

pnpm nx lint cli --skip-nx-cache
node_modules/.bin/vitest run packages/cli/bin/shopify-dev-tools-data.test.js --config packages/cli/vite.config.ts
pnpm nx bundle cli --skip-nx-cache

After bundling, verify packages/cli/dist/data contains public .json.gz schemas and types/index.json, but no bourgeois assets or raw dev-tools schema JSON.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes; none are needed
  • I've considered analytics changes; none are needed
  • This is not a user-facing behavior change, so no changeset is required

Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 22, 2026
@durga256
durga256 force-pushed the bundle-shopify-dev-tools-with-cli branch from 1a8446e to be23b4d Compare July 22, 2026 18:45
@durga256
durga256 force-pushed the remove-shopify-dev-tools-experiments branch from 7068df3 to 5ae7da7 Compare July 22, 2026 18:45
Assisted-By: devx/22639ada-bb5c-40ca-975b-7d13753f1353
@durga256
durga256 force-pushed the bundle-shopify-dev-tools-with-cli branch from be23b4d to ca94b41 Compare July 22, 2026 18:52
@durga256
durga256 force-pushed the remove-shopify-dev-tools-experiments branch from 5ae7da7 to 7624897 Compare July 22, 2026 18:52
@github-actions

Copy link
Copy Markdown
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. no-pr-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant