[Security] Harden downloadFile to check for non-2xx status codes - #7760
[Security] Harden downloadFile to check for non-2xx status codes#7760gonzaloriestra wants to merge 1 commit into
Conversation
Hardened `downloadFile` in `packages/cli-kit/src/public/node/http.ts` to validate `res.ok` before piping. If the response is not successful, the function now destroys the file stream, removes the partial file, and rejects the promise with a descriptive error message including the HTTP status code. Added a regression test in `packages/cli-kit/src/public/node/http.test.ts`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
downloadFilefunction previously did not check the response status code, which could result in error pages being saved as files and the promise resolving successfully even on failure.WHAT is this pull request doing?
Hardens
downloadFileinpackages/cli-kit/src/public/node/http.tsby validatingres.okbefore piping the response body. If the response is not successful, it destroys the file stream, removes the partial file, and rejects the promise with an error message containing the status code.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 490676649903503427 started by @gonzaloriestra