Skip to content

[Security] Harden downloadFile to check for non-2xx status codes - #7760

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-download-file-490676649903503427
Closed

[Security] Harden downloadFile to check for non-2xx status codes#7760
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-download-file-490676649903503427

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The downloadFile function previously did not check the response status code, which could result in error pages being saved as files and the promise resolving successfully even on failure.

WHAT is this pull request doing?

Hardens downloadFile in packages/cli-kit/src/public/node/http.ts by validating res.ok before piping the response body. If the response is not successful, it destroys the file stream, removes the partial file, and rejects the promise with an error message containing the status code.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 490676649903503427 started by @gonzaloriestra

Hardened `downloadFile` in `packages/cli-kit/src/public/node/http.ts` to validate `res.ok` before piping. If the response is not successful, the function now destroys the file stream, removes the partial file, and rejects the promise with a descriptive error message including the HTTP status code. Added a regression test in `packages/cli-kit/src/public/node/http.test.ts`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant