[Security] Redact secrets in app env pull output - #7693
Conversation
This change ensures that sensitive environment variables, specifically `SHOPIFY_API_SECRET`, are redacted with `****` in the console output and diffs generated by the `app env pull` command. The unredacted secrets are still correctly written to the `.env` file on disk, but they are masked in terminal logs and history to prevent accidental exposure. Changes: - In `packages/app/src/cli/services/app/env/pull.ts`, created `redactedValues` and used `patchEnvFile` to generate redacted content for display. - Updated `packages/app/src/cli/services/app/env/pull.test.ts` to verify redaction in console snapshots while ensuring file content remains complete.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Redact sensitive secrets (SHOPIFY_API_SECRET) from the console output and diffs generated by the
shopify app env pullcommand. This improvement prevents secrets from being leaked in terminal logs, history, or screen-sharing sessions, while maintaining the full secret in the actual.envfile on disk.PR created automatically by Jules for task 5069231579065351227 started by @gonzaloriestra