[Tests] Remove filesystem mocks in include-assets-step.test.ts - #7685
Conversation
Refactor include-assets-step.test.ts to use real filesystem operations
within a temporary directory instead of mocking @shopify/cli-kit/node/fs.
This aligns with the codebase's testing protocol and ensures more robust
verification of the include_assets build step.
- Replaced vi.mock('@shopify/cli-kit/node/fs') with real fs utilities.
- Implemented setupTestEnvironment helper for test isolation.
- Updated all 41 test cases to use inTemporaryDirectory.
- Applied linter fixes for vitest/prefer-expect-resolves.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
Merge activity
|
2 participants
WHY are these changes introduced?
Following the tester protocol to remove filesystem mocks and use real temporary directories instead for more reliable and maintainable tests.
WHAT is this pull request doing?
Refactors
packages/app/src/cli/services/build/steps/include-assets-step.test.tsto use real filesystem operations in a temporary directory instead of mocking@shopify/cli-kit/node/fs.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 11050273548128478750 started by @gonzaloriestra