Skip to content

[Performance] Remove redundant JSON serialization in analytics - #7683

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-remove-redundant-json-cycle-3531353586136633232
Closed

[Performance] Remove redundant JSON serialization in analytics#7683
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-remove-redundant-json-cycle-3531353586136633232

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

Removed a redundant JSON.parse(JSON.stringify(payload)) cycle in packages/cli-kit/src/public/node/analytics.ts.

JSON.stringify automatically omits properties with undefined values, so the explicit cycle used to strip them was unnecessary as sanitizePayload performs its own JSON.stringify/JSON.parse cycle immediately after.

This change reduces CPU overhead and memory allocations during analytics reporting.

How to test your changes?
CI


PR created automatically by Jules for task 3531353586136633232 started by @gonzaloriestra

Removed a redundant `JSON.parse(JSON.stringify(payload))` cycle in `packages/cli-kit/src/public/node/analytics.ts`.

`JSON.stringify` automatically omits properties with `undefined` values, so the explicit cycle used to strip them was unnecessary as `sanitizePayload` performs its own `JSON.stringify`/`JSON.parse` cycle immediately after.

This change reduces CPU overhead and memory allocations during analytics reporting.

Verified with unit tests, lint, and type-check.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant