[Performance] Remove redundant JSON serialization in analytics - #7683
[Performance] Remove redundant JSON serialization in analytics#7683gonzaloriestra wants to merge 1 commit into
Conversation
Removed a redundant `JSON.parse(JSON.stringify(payload))` cycle in `packages/cli-kit/src/public/node/analytics.ts`. `JSON.stringify` automatically omits properties with `undefined` values, so the explicit cycle used to strip them was unnecessary as `sanitizePayload` performs its own `JSON.stringify`/`JSON.parse` cycle immediately after. This change reduces CPU overhead and memory allocations during analytics reporting. Verified with unit tests, lint, and type-check.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removed a redundant
JSON.parse(JSON.stringify(payload))cycle inpackages/cli-kit/src/public/node/analytics.ts.JSON.stringifyautomatically omits properties withundefinedvalues, so the explicit cycle used to strip them was unnecessary assanitizePayloadperforms its ownJSON.stringify/JSON.parsecycle immediately after.This change reduces CPU overhead and memory allocations during analytics reporting.
How to test your changes?
CI
PR created automatically by Jules for task 3531353586136633232 started by @gonzaloriestra