Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make automatically managed input linear under byte-fragmented lines.
Retained input now uses an amortized geometrically growing allocation instead of rebuilding the complete prefix on every call. Line scanners preserve their last inspected offset across managed fragments, avoiding repeated rescans of incomplete request/status lines, headers, chunk headers/extensions, and trailers.
The retained allocation remains behind the existing
unconsumedpointer/length ABI. Aliased callers may safely pass that retained pointer back toparse()even when growth moves the allocation. Reset, error, and destruction paths release it with its original layout.Deterministic Rust/WASM instrumentation regressions verify linear aggregate copies and scans across 4,096 single-byte fragments, including CR/LF split resumption. A Rust regression also forces repeated growth while passing the public retained pointer back as input.
Validation: full Rust parser suite and focused rebuilt SIMD/non-SIMD WASM issue suite pass. Independent review found no blockers. The local Binaryen 108 does not support the repository's newer
--enable-bulk-memory-optspelling, so equivalent builds used--enable-bulk-memory.This fixes SEC-10 from #38.