Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define safe, unambiguous coordinates for automatically managed input.
parse()andpositionnow report only bytes consumed from the current call's input, excluding any retained prefix.parsedcontinues to count every stream byte exactly once.Event and callback ranges index an explicit
event_databacking buffer. Without a retained prefix this is the caller's current input; when managed bytes are prepended, Milo owns the aggregate until the next parse, reset, or destruction. Rust exposes an unsafe accessor with the unmanaged-input lifetime contract, C++ can read the fields directly, and WebAssembly exposes pointer/length getters.The retained buffer continues to contain only the unconsumed suffix. Mirrored Rust/WASM regressions validate current-call counts and exact aggregate backing bytes, while the allocator regressions verify bounded ownership and release behavior.
Full Rust/fuzz, C++ reference, and 98-test WASM validation passes. Independent review found no blockers.
This fixes SEC-06 from #38.