Support Browser environments #4

Activity

1. ShogunPanda commented on May 2, 2024

   

   ShogunPanda

   on May 2, 2024

   Owner

   More actions

   Hi!
   Having Milo running on browsers it was already on my roadmap, but I was currently focusing on bringing Milo into Node internals without sacrificing perfomance.
   Anyway I think your PR looked fine, thanks a lot for this!
2. ShogunPanda

   closed this as completedin #5on May 3, 2024
3. CxRes commented on Jul 6, 2024

   

   CxRes

   on Jul 6, 2024

   More actions

   @MarcoPolo @ShogunPanda Can you provide some instructions for using this, say when the incoming stream is Uint8Array. Thanks in advance!
4. MarcoPolo commented on Jul 6, 2024

   

   MarcoPolo

   on Jul 6, 2024

   ContributorAuthor

   More actions

   Here's how I use it to read an HTTP message from a Duplex<Uint8Array> which, for reading, is basically a generator that returns Uint8Arrays. https://github.com/libp2p/js-libp2p-http-fetch/blob/main/src/fetch/index.ts#L97
5. ShogunPanda commented on Jul 7, 2024

   

   ShogunPanda

   on Jul 7, 2024

   Last edited by ShogunPanda

   Owner

   More actions

   @CxRes The example @MarcoPolo already contains that.

   If you want a even more isolated example, you think about something this for Node streams:

   const milo = require('@perseveranza-pets/milo')
   
   // Get the stream somehow
   const stream = getStream()
   
   // Declare a chunk pointer. We need in callbacks
   let lastChunk
   
   // Create a parser
   const parser = milo.create()
   
   // Declare our callbacks
   milo.setOnData(parser, (p, from, size) => {
     console.log(`Pos=${milo.getPosition(p)} Body: ${lastChunk.slice(from, from + size).toString()}`)
   })
   
   // Here we're passing the chunk directly, which will copy the data. 
   // In the real world it's better to use WASM backed buffers allocated with milo.alloc if possible.
   // Unless specify differently, a stream is always a sequence of Uint8.
   stream.on('data', chunk => {
     lastChunk = chunk
     const consumed = milo.parse(parser, chunk, chunk.length)
   
     // You should check here if all bytes were consumed.
   })

   I think you can easily adapt this example to WebStream.
   Is that enough?
6. CxRes commented on Jul 7, 2024

   

   CxRes

   on Jul 7, 2024

   Last edited by CxRes

   More actions

   @MarcoPolo @ShogunPanda Thank a bunch for your responses!

   I think you can easily adapt this example to WebStream.
   Is that enough?

   Not sure, though adapting it to a webstream is not a problem, I will have to give it a try when I get a chance. What I am trying to do is read a multipart (or possibly application/http in a later iteration) stream and would want to it break up in sequence of Fetch Response objects for each part body (which are little http like messages). So I want to be able to parse headers (don't need trailers) and pass on the little bodies as streams to the consumer. The important thing is I do not want chunk bodies forcing the consumer to wait for an entire part.

   I am doing this for a new protocol I am developing on HTTP for notifications called Per Resource Events. I am coming out with libraries for it and would be better able to show you what I mean once they online.