Repository navigation
首页切 Tab 滑动中在两页接缝处画一条分割线,遮住被竖切的卡片右缘 - #738
Merged
Merged
Conversation
切 Tab 是横向滑动(票 #706):两页紧挨着平移,容器是直角 Clip()—— 榜单页那张 112px 圆角 hero 被拦腰竖切,切出来的硬边和下一页直角 内容之间没有任何过渡,画面上是一道「尖」。 修法是在接缝处画一条竖向分割线(网易云翻页那种缝隙感): - 挂在 Clip 容器上(不是 strip 里),Absolute 定位在 oldX+width ——即左页右缘,正好盖住被竖切的卡片右缘; - 1 DIP 宽,取主题的 Border 色(和侧栏右缘、队列抽屉头下那条线 同一个 token); - 只在滑动中画:静止时接缝不在画面上,分割线也就不建; - 双向都管:左滑右滑接缝都在同一个位置(oldX+width)。 验证: - 新增 TestThePagerDrawsASeamBetweenTheTwoPagesWhileSliding:断滑动 中途接缝元素在、x 落在容器左沿+oldX+width、静止时没有; - 新增 TestRenderPagerSeamShots(BIU_SHOT_DIR):静止/滑动中途/ 走完三张图——滑动中途 x≈641 有一条竖线,另两张同一位置没有; - 新增 e2e(BIU_RUN_MYGO_E2E=1):真窗口 capture,pager-seam 在 树上且它的 bounds 里有墨,走完之后收掉。
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
PudMusic UI 截图截图测试已通过。
截图来自项目现有的 MyGo UI 测试渲染器,使用本地 fixture,不启动真实登录态。 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
根因
切 Tab 是横向滑动(票 #706):两页紧挨着平移(strip 用
Left(oldX)整条挪),而容器是直角Clip()。「尖」是两件事叠出来的:
Clip()把 hero 卡片拦腰竖切——被切的卡片右缘是一条硬竖边,下面直角内容直接露出,两页之间没有任何过渡。修法
滑动中在两页之间画一条竖向分割线(网易云翻页那种缝隙感):盖住被竖切的卡片右缘、弱化左右顶对齐差。
Clip容器上(不是 strip 里),Absolute定位——它要的位置是「容器里的接缝 x」(oldX + width,即左页右缘)。塞进 strip 里会跟着平移、而且占一段宽度把右页挤歪。ui.Divider一致),色取主题的Border(和侧栏右缘、队列抽屉头下那条线同一个 token,不硬编)。oldTab >= 0那一支里建,不在稳态那一支里。oldX + width同一个位置,一条就盖住两个方向。验证
TestThePagerDrawsASeamBetweenTheTwoPagesWhileSliding:断滑动中途接缝元素在(Label 「pager-seam」)、x 落在「容器左沿 + oldX + width」、宽 ≤ 8 DIP、高 > 0;静止时没有、走完之后收掉。TestRenderPagerSeamShots(BIU_SHOT_DIR):静止 / 滑动中途 / 走完三张图——滑动中途 x≈641 处有一条#dfdad4竖线(Border色),另两张同一位置没有。BIU_RUN_MYGO_E2E=1):真窗口capture,pager-seam在树上且它的 bounds 里有墨(比底色深的一条竖带),走完之后从树里消失。已知(与本票无关)
go vet -tags e2e ./internal/e2e/在 origin/main 上就红:menu_test.go:168用了不在作用域里的seedSession(它在startRealAppWith的参数里,用到的是startRealAppWithArgs里)。这一票没动它。TestSwitchingBackRestoresThatTabsScrollPosition在干净 main 上也红(同一报错),与本改动无关。CodeAnt-AI Description
Add a divider at the page seam during home tab transitions
What Changed
Impact
✅ Covered card edges during tab swipes✅ Clearer separation between pages✅ No divider on settled pages💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.