feat: package trusted hooks and local MCP tools - #12
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 371966b404
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| if (name === "cewp_retry") { | ||
| requireConfirmation("retry", args); | ||
| return retrySupervisedCheckpoint({ ...core, yes: true }); |
There was a problem hiding this comment.
When an MCP caller omits the schema-optional timeoutSeconds, this forwards undefined to retrySupervisedCheckpoint; that function persists the run and attempt as executing before runCodexExecAdapter rejects the missing timeout. A valid confirmed retry therefore fails without executing anything and leaves the authoritative run stuck in an in-progress state, so supply the CLI-equivalent default before entering Core or require the argument.
AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.
| checkpointId: binding.workflow.checkpointId, | ||
| owner: binding.execution.owner, | ||
| backend: binding.execution.backend, | ||
| status: "active", |
There was a problem hiding this comment.
When a host binding includes a worktree, this registry entry is always written as active, but no workflow completion, cancellation, replacement-without-a-worktree, or cleanup path updates this integration-side ownership file. Because loadOwnershipRecords treats every non-released entry as live, the completed workflow can permanently block later checkpoints or runs from claiming that task/worktree; transition or remove this claim when its Core lifecycle ends.
AGENTS.md reference: AGENTS.md:L6-L6
Useful? React with 👍 / 👎.
Summary
Validation
This is part 2 of the ordered Phase 11-14 publication series.