Skip to content

feat(configuration): activate workflow with build and flash#28

Merged
charlesmadjeri merged 1 commit into
devfrom
cma/feat-build-flash-ui-workflow
May 12, 2026
Merged

feat(configuration): activate workflow with build and flash#28
charlesmadjeri merged 1 commit into
devfrom
cma/feat-build-flash-ui-workflow

Conversation

@charlesmadjeri
Copy link
Copy Markdown
Contributor

@charlesmadjeri charlesmadjeri commented May 10, 2026

Issue: Sentience-Robotics/lucy_ros2#105

PR summary

Activate workflow & configure-pipeline

  • Dry run then activate: The modal runs ConfigurePipeline with dry_run: true against the TARGET preset (mapping_file = target name) for validation/generate feedback only.
  • Wet run on active: After /config/activate promotes the target to active, the workflow starts ConfigurePipeline again with mapping_file: '' (active YAML on disk), dry_run: false, boards_to_flash from the modal, and build_only from BUILD ONLY.
  • ACTIVATE ONLY: Skips build/flash entirely after /config/activate and refreshes config/active state.
  • Board selection: Empty selection no longer maps to “flash all boards”; it forces ACTIVATE ONLY and guards runActivateWorkflow so build/flash never runs without an explicit board selection when boards exist.
  • Mutual exclusion: BUILD ONLY and ACTIVATE ONLY clear each other when one is turned on; switches stay enabled unless the workflow is running (no cross-disabling).

Pipeline / robot metadata (related)

  • After a successful flash (non-empty flashed boards), active_meta.yaml records flashed_name / flashed_at; GetConfig returns flashed_config_name / flashed_at for the UI FLASHED tag.

@charlesmadjeri charlesmadjeri self-assigned this May 10, 2026
Base automatically changed from cma/hardware-config-ui to dev May 10, 2026 22:32
Signed-off-by: Charles Madjeri <80175305+charlesmadjeri@users.noreply.github.com>
Copy link
Copy Markdown

@Arcod7 Arcod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please next time split that in separate PR's to make it easier to review.
Otherwise LGTM

@Arcod7
Copy link
Copy Markdown

Arcod7 commented May 12, 2026

I'm for example talking about all of the UI changes that are not important and takes a lot of time, this could be all outsourced into another PR

@charlesmadjeri charlesmadjeri merged commit 0b6f320 into dev May 12, 2026
@charlesmadjeri charlesmadjeri deleted the cma/feat-build-flash-ui-workflow branch May 12, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants