[AMD][Qwen3.5] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.19-rocm720-mi35x-20260908 - #2906
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
fa8db9f to
d5db3f5
Compare
…Cm image to v0.5.19-rocm720-mi35x-20260908 Co-Authored-By: ChangLiu0709 <190883410+ChangLiu0709@users.noreply.github.com>
yichiche
changed the title
d5db3f5 to
f8205d6
Compare
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299684481 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good, straightforward image version bump.
Reviewed: the configs/amd-master.yaml change is a single-field image tag bump for qwen3.5-fp4-mi355x-sglang-agentic-mtp, with multinode: false so the srt-slurm container/image invariant doesn't apply; confirmed no other fields changed. Confirmed the perf-changelog.yaml entry is appended at the tail only, follows the existing kebab-case schema, and matches the image change described.
Extended reasoning...
Overview
This PR bumps the Docker image tag for the qwen3.5-fp4-mi355x-sglang-agentic-mtp recipe in configs/amd-master.yaml from v0.5.18-rocm720-mi35x-20260829 to v0.5.19-rocm720-mi35x-20260908, and appends a matching entry to perf-changelog.yaml. Verified via git diff that only the image: line changed in the config (all other fields — model, precision, framework, scenarios, multinode: false — are untouched), and the changelog addition is a well-formed append at the very end of the file with no modification to existing bytes.
Security risks
None. This is a version-tag change to a config value consumed by the benchmark harness; no code execution paths, auth, or crypto are touched.
Level of scrutiny
Low. This matches the repository's established pattern for "simple, mechanical" changes explicitly called out as approvable: a version bump with no logic changes, correctly paired with the required changelog entry. multinode: false means the srt-slurm "container must equal image" cross-file invariant does not apply, so there's no additional consistency check needed across recipe/master config files.
Other factors
No bug-hunter findings, no PR conversation objections, and the PR author's own description matches what the diff actually does. AGENTS.md's core requirements (changelog entry present, append-only preserved, kebab-case fields) are satisfied.
This review covers commit fa8db9f, which is no longer the latest commit on this pull request; later commits are not covered by it.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
4 similar comments
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
1 participant
Summary
Update the SGLang ROCm image for the Qwen3.5 MXFP4 MI355X AgentX recipe from
lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260829tolmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908.Recipes touched:
qwen3.5-fp4-mi355x-sglang-agentic-mtpThe target tag was verified to exist on Docker Hub under
lmsysorg/sglang-rocm(HTTP 200). Note that the ROCm-suffixed tag does not exist underlmsysorg/sglang.Test plan
full-sweep-fail-fastsweep passes.Note
Low Risk
Single-container image pin in benchmark config plus changelog; no application logic, auth, or data-path changes.
Overview
Updates the
qwen3.5-fp4-mi355x-sglang-agentic-mtpbenchmark recipe to uselmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908instead ofv0.5.18-rocm720-mi35x-20260829. Model, runner, agentic-coding scenario, and search space are unchanged.Adds a
perf-changelog.yamlentry for that config key andagentic-codingscenario, linked to this PR, so the image bump is recorded in perf history.Reviewed by Cursor Bugbot for commit f8205d6. Bugbot is set up for automated code reviews on this repo. Configure here.